Skip to content

[6.2][SwiftCaching] Don't leak output path in the explicit module map JSON #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release/6.2
Choose a base branch
from
Open

[6.2][SwiftCaching] Don't leak output path in the explicit module map JSON #1885

wants to merge 1 commit into from

Conversation

cachemeifyoucan
Copy link
Contributor

  • Explanation:Using an abstract name for the module path for swift caching build because caching build loads modules directly from CAS and the path is insignificant. The abstract module path allows cache hits across different output locations.
  • Scope:Allow swift caching to have more cache hit opportunities
  • Issues:rdar://149960868
  • Original PRs:[SwiftCaching] Don't leak output path in the explicit module map JSON #1883
  • Risk:Low. Swift caching only.
  • Testing: Covered by original unit tests.
  • Reviewers: @artemcm

@cachemeifyoucan
[SwiftCaching] Don't leak output path in the explicit module map JSON
876a967 
Using an abstract name for the module path for swift caching build
because caching build loads modules directly from CAS and the path is
insignificant. The abstract module path allows cache hits across
different output locations.

rdar://149960868
(cherry picked from commit 90c6ece)
@cachemeifyoucan cachemeifyoucan requested a review from a team as a code owner April 29, 2025 17:34
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cachemeifyoucan